Dark mode button #1874
Merged
Dark mode button #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
reviewed
Feb 20, 2024
stevekinney
approved these changes
Feb 21, 2024
rossedfort
reviewed
Feb 22, 2024
|
I noticed the designs don't specify a shadow for hover state, only focus, but I think we can follow up on this later. |
rossedfort
requested changes
Feb 22, 2024
Oh no! Good catch. Thanks Ross! |
rossedfort
approved these changes
Feb 22, 2024
rossedfort
pushed a commit
that referenced
this pull request
Feb 23, 2024
* update styling for destructive button * add standard button styling * secondary button * ghost button * make updates based on comments * update border * fix the focus states and remove shadow from hover * update tests * destructive remove shadow add hover bg * update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Added new button styles to button component
Screenshots (if applicable) 📸
Design Considerations 🎨
https://www.figma.com/file/LNN3Cu8Akqb240WmJmbtsS/Holocene?node-id=3789%3A216118&mode=dev
Will confirm that this looks okay with Ash.
Testing 🧪
How was this tested 👻
WILL UPDATE TESTS ONCE DESIGN CONFIRMS THESE ARE GOOD TO GO
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Please check story book and make sure buttons look like they do in figma designs
Checklists
Light
Dark
Draft Checklist
Merge Checklist
Issue(s) closed
dark mode buttons
Docs
Any docs updates needed?