Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined translated values #1877

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Feb 22, 2024

Description & motivation 💭

Fixes undefined values when translate files aren't loaded before variable is defined.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added updated

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:43pm

@laurakwhit laurakwhit merged commit cf44b90 into main Feb 22, 2024
11 checks passed
@laurakwhit laurakwhit deleted the fix-undefined-translated-values branch February 22, 2024 19:09
rossedfort pushed a commit that referenced this pull request Feb 23, 2024
* Remove unlimited attempts copy variable

* Remove no expiration copy variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants