Remove double encoding for API URL parameters #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
changed the title
Alex-Tideman
changed the title
rossedfort
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
With proto/SCREAMING ENUM updates, WorkflowIds that contain certain letter combinations can't be found by api due to double encoding. This PR removes the double encoding if ui-server version is
>= 2.23.0and keeps it if less than that.Patterns with issues:
Quotes:
someId'|another|test|__test__underscore|test|data'id="x_'some/value'"Slashes:
Example(1/1)Spaces:
Example(1 0)! with :
!foo:barAll of these WorkflowIds 404 with double encoding, and do not 404 with single encoding.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Fixes:
#1987
#2129
#1084
Docs
Any docs updates needed?