Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Nav #2197

Merged
merged 22 commits into from
Jul 15, 2024
Merged

Mobile Nav #2197

merged 22 commits into from
Jul 15, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Jul 10, 2024

Description & motivation 💭

To improve our mobile experience and give more horizontal real estate when on small screens.

Besides adding a Bottom Nav, there's been several other changes:

  1. Pass in the linkList as a prop with all the necessary information to render it - href, icon, label, tooltip, divider, external, hidden, animate. There are no more slots, each global layout is responsible for providing the linkList and the Navs (side/bottom) will render them for you in the order providered.
  2. The Namespace switcher is available on all pages now. It will show the current namespace or the last used namespace. This allows you to jump to a namespace whenever in the app.
  3. There is also some smaller general UI updates to improve responsiveness and dark mode.

Screenshots (if applicable) 📸

Screenshot 2024-07-12 at 9 32 13 AM Screenshot 2024-07-12 at 9 32 23 AM Screenshot 2024-07-12 at 9 32 44 AM Screenshot 2024-07-12 at 9 32 52 AM Screenshot 2024-07-12 at 9 32 59 AM Screenshot 2024-07-12 at 9 33 48 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

  • Better slide transition?

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from rossedfort and a team as code owners July 10, 2024 18:41
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 2:50pm

@Alex-Tideman Alex-Tideman requested a review from laurakwhit July 10, 2024 18:43
Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few small suggestions

src/lib/components/bottom-nav-links.svelte Outdated Show resolved Hide resolved
src/lib/components/bottom-nav-settings.svelte Outdated Show resolved Hide resolved
@Alex-Tideman Alex-Tideman merged commit f418976 into main Jul 15, 2024
11 checks passed
@Alex-Tideman Alex-Tideman deleted the mobile-nav branch July 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants