Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorkflowPropertiesModified event and group with Marker and SAUpsert into Other group category #2219

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Jul 19, 2024

Description & motivation 💭

Remove Command and Marker category and add Other category. Command is a confusing and overloaded term, and is not used often. Same with Marker. Move them both into Other category and add WorkflowPropertiesModified to Other as well. Do not filter any categories out by default, show all events.

Screenshots (if applicable) 📸

Screenshot 2024-07-19 at 9 22 07 AM Screenshot 2024-07-19 at 9 22 21 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from stevekinney, rossedfort and a team as code owners July 19, 2024 14:21
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:21pm

@Alex-Tideman Alex-Tideman requested a review from laurakwhit July 19, 2024 15:04
@Alex-Tideman Alex-Tideman merged commit 7f351f8 into main Jul 19, 2024
11 checks passed
@Alex-Tideman Alex-Tideman deleted the recategorize-events branch July 19, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants