Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text styles in navigation badge #2253

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

rossedfort
Copy link
Contributor

@rossedfort rossedfort commented Aug 5, 2024

Description & motivation 💭

  • move whitespace-nowrap from containing div to tooltip div only.
  • add text-center to slot container

Needed to support new copy in promotion nav badge in cloud

Screenshots (if applicable) 📸

Screenshot 2024-08-05 at 1 41 29 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 7:42pm

@rossedfort rossedfort merged commit 771e3f1 into main Aug 5, 2024
14 checks passed
@rossedfort rossedfort deleted the navigation-badge-whitespace-fix branch August 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants