Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox component updates #2369

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Combobox component updates #2369

merged 5 commits into from
Oct 4, 2024

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

  • Fixes Combobox height to match other Input components
  • Removes buttons from Combobox input
  • Adds data-1p-ignore to inputs

Screenshots (if applicable) 📸

Before After
Screenshot 2024-10-04 at 10 09 48 AM Screenshot 2024-10-04 at 11 32 42 AM
Screenshot 2024-10-04 at 10 09 57 AM Screenshot 2024-10-04 at 11 32 13 AM
Screenshot 2024-10-04 at 10 10 19 AM Screenshot 2024-10-04 at 11 32 27 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested a review from rossedfort as a code owner October 4, 2024 17:57
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:57pm

@laurakwhit laurakwhit merged commit 7757a34 into main Oct 4, 2024
14 checks passed
@laurakwhit laurakwhit deleted the update-combobox-styles branch October 4, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants