Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Holocene updates #2486

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Small Holocene updates #2486

merged 4 commits into from
Jan 8, 2025

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Jan 7, 2025

Description & motivation 💭

  • Fixes Combobox height to match Select component's height
Before After
Screenshot 2025-01-07 at 9 34 15 AM Screenshot 2025-01-07 at 9 33 29 AM
  • Adds id prop to PaginatedTable and maxHeight prop to API PaginatedTable
  • Adds circle-check-filled and xmark-filled icons
    Screenshot 2025-01-07 at 9 28 53 AM

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 9:42pm

@laurakwhit laurakwhit force-pushed the small-holocene-updates branch from 947db90 to e7811ec Compare January 7, 2025 16:27
@laurakwhit laurakwhit marked this pull request as ready for review January 7, 2025 16:38
@laurakwhit laurakwhit requested a review from rossedfort as a code owner January 7, 2025 16:38
@laurakwhit laurakwhit merged commit a1bcfec into main Jan 8, 2025
14 checks passed
@laurakwhit laurakwhit deleted the small-holocene-updates branch January 8, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants