-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Kendalls Tau metric when used in graph mode #2739
Conversation
You are owner of some files modified in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for this change.
I removed a padding op that seemed unnecessary. |
@theadactyl Just another TF ecosystem duplication reminder, we have this also in TFP: |
This is incorrect - the tfp implementation (1) can't be used as a keras metric (2) is not approximate. I'm the author of both, don't blame me for the complexities of TF packaging. This particular implementation is an online O(n) approximate algorithm that is much better suited for use as a metric in machine learning. The TFP implementation is an O(n^2) algorithm. |
|
/cc @MarkDaoust |
I was exactly referring to the ecosystem boundaries and packaging. See our original 2020 thread: |
Description
Blocked by #2740Brief Description of the PR:
The metric was only working in eager mode. This fix makes it work in graph mode too.
Type of change
Checklist:
How Has This Been Tested?
The metric was giving NaNs when running in graph mode. I modified the test to check against the NaN values.