-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add core migration guide #774
DOC: Add core migration guide #774
Conversation
* Remove markdown migration tracker in favor of GitHub project
What will be the pipeline from keras-contrib to core? |
Hi @bhack thanks for bringing this up! So given that keras-contrib is being deprecated I think a logical path is for contributions to be submitted to addons prior to requesting a move to Keras core. I checked some issues on keras-contrib and most issues are without responses (last PR was in the summer) so AFAIK there should be no more submissions to keras-contrib as PRs. Does that conflict with your understanding? |
IMHO we could put keras-contrib in read only mode as soon as it is possible. But then it will hard to explain to user that you need to go here in a Tensorflow repo to then go on Keras core that It Is not in TF owned repo but still Tensorflow only API from April 2020. What kind of narrative we are building for new users? |
|
||
|
||
### Criteria for Migration | ||
* The addition is widely used throughout the community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any kind of telemetry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#236 needs to be completed. We were/are waiting for adoption to pick up along with TF2 adoption:
https://pypistats.org/packages/tensorflow-addons
Agree that it is a splintered experience for new users. Some questions that I can not provide answers to:
Ultimately it's something I think we need to streamline... but this particular PR is the path from Addons to TF-core and I don't think that process changes based on the answers to the above questions. |
@seanpmorgan I agree with your points but I really don't understand when Keras it will be only an API for Tensorflow (from april 2020) what tf.keras will be? |
@seanpmorgan , to answer your questions:
If you have any other questions, feel free to ask. |
Actually I can't archive keras-contrib, I don't think I have the rights. I changed the readme to make it clear that this repo is deprecated. |
I am ok to abandon the multi-backend but I really don't understand ehy Keras needs to be under another org if It will be Tensorflow only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We don't want Keras to be tied to Google's rules and processes. We want it to be really open source. Unlike tensorflow, google won't have an internal version of keras. Everything will be public, on the github repo. That's the direction here. We'll see how it turns out in practice. |
@gabrieldemarmiesse So what we will do with https://github.com/tensorflow/tensorflow/labels/comp%3Akeras ? |
It's similar to when users open issues on scipy and those issues get
migrated to numpy. We're not the only ones having the task of dispatching
issues. For exemple, people might open an issue in the torchvision repo and
this issue gets redirected to pytorch. Do you know a way to handle it
automatically?
El jue., 19 dic. 2019 21:54, bhack <[email protected]> escribió:
… @gabrieldemarmiesse <https://github.com/gabrieldemarmiesse> So what we
will do with https://github.com/tensorflow/tensorflow/labels/comp%3Akeras
?
How we will avoid the natural behavior to create these there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#774?email_source=notifications&email_token=ADCLMK3DMCLWE7FNVSX74Y3QZPNSFA5CNFSM4J3BYIZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHLABFI#issuecomment-567672981>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCLMK7VQKEAFSDY3MK7X53QZPNSFANCNFSM4J3BYIZA>
.
|
It Is not the same IMHO as scipy or Torchvision examples. |
Also It will be quite complex to request to users/devs to split issues/PRs between Keras and TF repo when the feautre It Is going to impact or request TF changes. |
Well, it may be an issue, we'll see with the time. @bhack Do you have another organisation/process in mind that would be better? |
I honestly don't know how we got into this situation because I didn't attend the internal strategica meetings about Keras roadmap. I.e. Things like the one below without a Keras branded namespace IMHO it Is not going to be a robust storytelling as Keras will be soon totally dedicated to the Tensorflow project:
|
@gabrieldemarmiesse Thanks! The new README page seems clear to me
Thanks for the info. IMO its a bit confusing, but I understand the desire to keep it as a fully open-source project with its own governance.
Not exactly a fix, but because there is a paid team to manage/triage issues on TF-core, end users should at least be directed to the correct place after review. |
Thanks for the review all! I do think this has diverged a bit from the PR... probably best to discuss these roadmap decisions on keras-governance. |
Sorry about invading this PR @seanpmorgan . And thanks for the PR :) |
The governance original thread was at keras-team/governance#2 but nobody reply. |
@seanpmorgan @gabrieldemarmiesse @bhack -- I think we are meant to schedule a meeting to discuss this, not sure why it hasn't happen yet, meanwhile JFYI |
@tanzhenyu I am ok with this. Waiting for a @seanpmorgan free slot. |
@tanzhenyu @bhack We have our monthly meeting this Thursday (Sept 3rd 11am PT): Do you think we could cover this with @karmel and your team during that or would you prefer a focused meeting to discuss? |
I believe it's be great to have separate focused meeting for both of them, so whoever is interested in cv or nlp can attend. But if not, 09/03/20 11am PST works for me -- Can you invite me (so I will invite Francois) |
Closes #686