Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_config and from_config methods to DenseVariational_v2 #1695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Frightera
Copy link
Contributor

Fixes the issue #1627:
NotImplementedError: Layer DenseVariational has arguments in __init__ and therefore must override get_config

Some unit tests are failing due to an internal issue in TF-Nightly as of 17/02/2023. Please find the gist here to see the fix.

Thanks!

@Frightera Frightera changed the title Add get_config and from_config methods Add get_config and from_config methods to DenseVariational_v2 Feb 17, 2023
@Frightera
Copy link
Contributor Author

Hi @csuter, is there any chance that you can take a look at this tiny PR?

Thanks.

@csuter
Copy link
Member

csuter commented May 19, 2023

thanks for sending.

please add some unit tests covering the new behavior, in the corresponding test file.

would any other layers benefit from adding the same new behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants