Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix narrowing conversion in metal header #17890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenbinlyuTT
Copy link
Contributor

Ticket

N/A

Problem description

Compiling an external metal cpp program with clang++-17 fails with the following error

.../tt_metal/api/tt-metalium/dispatch_settings.hpp:82:59: error: non-constant-expression cannot be narrowed from type 'int' to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
   82 |                 DispatchSettingsContainerKey k{core_type, hw_cqs};
      |                                                           ^~~~~~

What's changed

Changed the loop variable to be u32, also removed one unused header.

Checklist

@wenbinlyuTT wenbinlyuTT force-pushed the fix_narrowing_conversion branch from 9114589 to a57726c Compare February 18, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant