Add type conversion pattern for empty op #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Feb 19, 2025
mmanzoorTT
force-pushed
the
mmanzoor/empty-boolean-tensor
branch
2 times, most recently
from
c0d7372 to
d1eb6ea
Compare
Stablehlo to TTIR conversion uses a customized type convertor. Use the same type convertor for tensor::empty op as well to ensure consistency.
mmanzoorTT
force-pushed
the
mmanzoor/empty-boolean-tensor
branch
from
d1eb6ea to
23f0b9a
Compare
vwellsTT
pushed a commit
that referenced
this pull request
Feb 20, 2025
Stablehlo to TTIR conversion uses a customized type convertor. Use the same type convertor for tensor::empty op as well to ensure consistency. ### Ticket #2161 ### Problem description Stablehlo to TTIR conversion pass apply custom pass to convert unsupported data types to supported data types. which is not applied to tensor::emptyop. This causes stablehlo to TTIR conversion to fail for empty op with unsupported data types. ### What's changed Add a conversion pattern for tensor::emptyop to apply custom type convertor and match the output with stablehlo to TTIR conversion pass. ### Checklist - [X] New tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stablehlo to TTIR conversion uses a customized type convertor. Use the same type convertor for tensor::empty op as well to ensure consistency.
closes #2161
Ticket
#2161
Problem description
Stablehlo to TTIR conversion pass apply custom pass to convert unsupported data types to supported data types. which is not applied to tensor::emptyop. This causes stablehlo to TTIR conversion to fail for empty op with unsupported data types.
What's changed
Add a conversion pattern for tensor::emptyop to apply custom type convertor and match the output with stablehlo to TTIR conversion pass.
Checklist