Remove PROCESS_RECEIVE_NO_TRUDP callback that was never called. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 36638bb8090f4fbbeb44a7e24c33165d1360329d into 1b381f8 - view on LGTM.com fixed alerts:
|
chernikovdmitry
requested changes
Mar 16, 2020
chernikovdmitry
approved these changes
Mar 17, 2020
kirill-scherba
approved these changes
Mar 23, 2020
kirill-scherba
requested review from
chernikovdmitry and
kirill-scherba
and removed request for
kirill-scherba and
chernikovdmitry
Si1ver
changed the title
Si1ver
force-pushed
the
fix/process-revceive-notrudp-callback
branch
from
e39528c
to
49af505
Compare
Si1ver
changed the title
Si1ver
force-pushed
the
fix/process-revceive-notrudp-callback
branch
from
49af505
to
7096933
Compare
|
This pull request fixes 1 alert when merging 70969339e8ff4a6f3e8af6d0f6c04618343887d1 into bb21ebf - view on LGTM.com fixed alerts:
|
Si1ver
force-pushed
the
fix/process-revceive-notrudp-callback
branch
from
7096933
to
9a9ca03
Compare
|
This pull request fixes 1 alert when merging 9a9ca03 into bb21ebf - view on LGTM.com fixed alerts:
|
chernikovdmitry
approved these changes
Apr 19, 2020
chernikovdmitry
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes PROCESS_RECEIVE_NO_TRUDP that was never called for non-Trudp packets but was called for Trudp packets with unknown packet type and valid checksum.