Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ #484 | should make vagrant plugin can install by command #485

Conversation

hieptranquoc
Copy link

connect #484
Please review this PR, thx you!

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2018

CLA assistant check
All committers have signed the CLA.

@hieptranquoc
Copy link
Author

example config in teracy-dev-essential

- _id: "essential-1"
      name: vagrant-libvirt
      # version: "" # empty means latest by default.
      state: "installed" # empty means do nothing.
      enabled: true

      # Add config args if you need to install by command
      plugin_vars:
        # example
        configure_args: with-libvirt-include=/usr/local/include/libvirt with-libvirt-lib=/usr/local/lib
        # If you have issues about gem, add gem config you need:
        # example
        # gem_home: "~/.vagrant.d/gems"
        # GEM_PATH:
        # PATH:
        # Some key: value

      # Add options to install command
      # see more at https://www.vagrantup.com/docs/cli/plugin.html#plugin-install
      # command_opts:
        # example
        # plugin-version: '< 0.0.43'
        # local:

@hieptranquoc
Copy link
Author

Examples cases need to install by command:
https://github.com/vagrant-libvirt/vagrant-libvirt#possible-problems-with-plugin-installation-on-linux

CONFIGURE_ARGS='with-ldflags=-L/opt/vagrant/embedded/lib with-libvirt-include=/usr/local/include/libvirt with-libvirt-lib=/usr/local/lib' GEM_HOME=~/.vagrant.d/gems GEM_PATH=$GEM_HOME:/opt/vagrant/embedded/gems PATH=/opt/vagrant/embedded/bin:$PATH vagrant plugin install vagrant-libvirt

@hieptranquoc hieptranquoc force-pushed the improvement/#484-should-make-libvirt-install-correctly branch from ece3c94 to 55adfc3 Compare October 1, 2018 18:22
@hoatle
Copy link
Member

hoatle commented Oct 2, 2018

This is still a little specific use case, we'll review and consider merging this when there are at least 2 use cases (2 plugins) that require the changes.

With the vagrant-libvirt plugin use case, let users manage to install it themselves for now.

@hoatle hoatle removed request for phuonglm and datphan October 2, 2018 02:41
@hieptranquoc hieptranquoc force-pushed the improvement/#484-should-make-libvirt-install-correctly branch from 55adfc3 to ff4637d Compare October 3, 2018 10:18
@ghost ghost assigned hieptranquoc Oct 3, 2018
@ghost ghost removed the stag:under-review label Oct 3, 2018
@hieptranquoc hieptranquoc deleted the improvement/#484-should-make-libvirt-install-correctly branch October 29, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants