Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to useDevice composable #188

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

wazolab
Copy link
Member

@wazolab wazolab commented Mar 6, 2024

  • Remove plugins/device.ts
  • Create useDevice composable

It gives us more flexibility with Storybook integration as we don't have to inject plugin into SB instance anymore.
It prepares component to be written with script setup

@wazolab wazolab self-assigned this Mar 6, 2024
@wazolab wazolab force-pushed the move-to-use-device-composable branch from 68ffaef to e0d1c8a Compare March 6, 2024 16:18
@wazolab wazolab requested a review from frodrigo March 6, 2024 16:19
@wazolab wazolab force-pushed the move-to-use-device-composable branch from e0d1c8a to 6bb1dcf Compare March 12, 2024 16:15
composables/useDevice.ts Outdated Show resolved Hide resolved
@frodrigo frodrigo merged commit e1b7c8e into develop Mar 12, 2024
1 check passed
@wazolab wazolab deleted the move-to-use-device-composable branch March 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants