Datatable filtering and sorting #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, rebase this branch. |
wazolab
force-pushed
the
172-datatable-filtering-and-sorting
branch
from
c214f0a to
a082cc7
Compare
|
@frodrigo: PR rebase ! |
wazolab
force-pushed
the
172-datatable-filtering-and-sorting
branch
19 times, most recently
from
93d3900 to
07e3998
Compare
wazolab
force-pushed
the
172-datatable-filtering-and-sorting
branch
from
07e3998 to
d957790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could do even better sorting / filtering with the latest version and avoid data transformation prior to rendering.
In new Vuetify version we have the ability to use raw data in sort & filter.
Usage of latest Vuetify version might create side-effects on other Vuetify components which is out of the scope of this PR.
How work Sort / Filter on DataTable
For value display in template, we are using an untouched
poisdata structure coming from the API.We are adding to
poisall composed fields with single string value (ex:addr,route, @frodrigo : do we have more specific cases ? ), this way we have conventional field to be displayed / sorted and filtered.During Sort & Filter we are using
valueToStringfunction in order to flatten array values on the fly as we can’t do it earlier. We need the array value forFieldComponent.