Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init trackers on page reload #441

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Init trackers on page reload #441

merged 1 commit into from
Dec 4, 2024

Conversation

wazolab
Copy link
Member

@wazolab wazolab commented Dec 4, 2024

No description provided.

@wazolab wazolab linked an issue Dec 4, 2024 that may be closed by this pull request
[Analytics] - When user gave his consent trackers aren't init after a page reload #440
Closed
@wazolab wazolab changed the title fix(analytics): init trackers on page reload #440 Init trackers on page reload Dec 4, 2024
@wazolab wazolab self-assigned this Dec 4, 2024
@wazolab wazolab added the bug Something isn't working label Dec 4, 2024
@wazolab wazolab modified the milestone: v1.24 Dec 4, 2024
@wazolab wazolab requested a review from frodrigo December 4, 2024 10:27
@wazolab wazolab marked this pull request as draft December 4, 2024 10:59
@wazolab wazolab force-pushed the 440-tracking-when-user-gave-his-consent-trackers-arent-init-after-a-page-reload branch from 546bfda to 808ba49 Compare December 4, 2024 16:13
@wazolab wazolab marked this pull request as ready for review December 4, 2024 16:13
@wazolab
Copy link
Member Author

wazolab commented Dec 4, 2024 •
edited
Loading

@frodrigo I kept Matomo initialisation linked to COOKIES_CONSENT config variable setting like it was before.
Only GTM init is linked linked to the user's consent.

As far as I understand we have 2 Matomo cases of usage :

  • Ours, internal, not subject to user's cookies consent (we are supposed to unset COOKIES_CONSENT var)
  • Client managed, subject to cookies consent (we are supposed to set COOKIES_CONSENT var)

Conclusion
Matomo setup is linked to the activation of Cookies Consent module in Vido.
GTM setup is linked to user's cookie consent.

@frodrigo frodrigo added the prod label Dec 4, 2024
@frodrigo frodrigo merged commit e71a9dd into develop Dec 4, 2024
4 checks passed
@wazolab wazolab deleted the 440-tracking-when-user-gave-his-consent-trackers-arent-init-after-a-page-reload branch December 4, 2024 17:03
@wazolab wazolab added this to the v1.24.1 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodrigo frodrigo Awaiting requested review from frodrigo

Assignees

@wazolab wazolab

Labels
bug Something isn't working prod
Projects
None yet
Milestone
v1.24.1
Development

Successfully merging this pull request may close these issues.

[Analytics] - When user gave his consent trackers aren't init after a page reload
2 participants
@wazolab @frodrigo