Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x11/mkvtoolnix): Fix build by using host-qmake6 #20786

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

fornwall
Copy link
Member

@fornwall fornwall commented Jul 6, 2024

Currently the build of mkvtoolnix fails with:

checking for qmake6... using supplied /data/data/com.termux/files/usr/lib/qt6/bin/qmake6
no: not all of the required Qt6 modules were found (needed: core )
configure: error: The Qt library version >= 6.2.0 is required for building MKVToolNix.

Don't know much about the Qt build system, is this change of qmake6 to host-qmake6 the correct fix here (ping @Biswa96)?

Copy link
Member

@Biswa96 Biswa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. But how did it compile before? The qmake6 Android binary should not work.

@fornwall fornwall merged commit cddcf4d into master Jul 7, 2024
5 checks passed
@fornwall fornwall deleted the fix-mkvtoolnix branch July 7, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants