fix(main/zsh): Fix zsh-newuser-install being run twice

[kenjipuro]

Zsh already automatically runs zsh-newuser-install as part of the newuser module. Running it manually in the system zshrc caused it to run twice.

Note that zsh-newuser-install automatically exits if the terminal's size is less than 72x15, so it might not run on the default Termux terminal size.

[TomJo2000]

Good catch.

[TomJo2000]

Note that zsh-newuser-install automatically exists if the terminal's size is less than 72x15, so it might not run on the default Termux terminal size.

Do you happen to have a source for that, because that might explain how I missed this initially.

[kenjipuro]

Note that zsh-newuser-install automatically exists if the terminal's size is less than 72x15, so it might not run on the default Termux terminal size.

Do you happen to have a source for that, because that might explain how I missed this initially.

Yes, here is a link to the check on the unofficial GitHub Zsh mirror: https://github.com/zsh-users/zsh/blob/master/Functions/Newuser/zsh-newuser-install#L114

I found this while I was debugging why it was running in an SSH environment but not in a normal Termux session.

[TomJo2000]

Okay so if $LINES is less than 15 or $COLUMNS is less than 72 it returns 1 (does not run).
That way around makes more sense to me.

[kenjipuro]

It is probably the reason why @gphg had trouble bringing the wizard up in #20604 (comment).

[TomJo2000]

Hmm maybe a notice would be good if that condition applies?

Something along the lines of:

# if zsh-newuser-install doesn't consider the terminal size "sane"
if (( ${LINES:-0} < 15 || ${COLUMNS:-0} < 72 )); then
# and no ~/.zshrc exists
[[ -r "${ZDOTDIR:-$HOME}"/.zshrc ]] || printf '%s\n' \
	'No ~/.zshrc exists' \
	'and zsh-newuser-install was not able to run.' \
	'Please consider zooming out by pinching' \
	'to increase the terminal size' \
	'and running zsh-newuser-install manually.' \
	'For first-run setup.' \
fi

[kenjipuro]

I think handling that situation should be solved on upstream because it is not a Termux-specific issue.

As for the implementation itself, we do not need to check if zshrc exists because the function is either being ran automatically by zsh/newuser when no start-up files are found (see zshmodules(1)) or being ran manually by a user that wants to set them up.

Maybe something like this (considering how the other checks are handled):

# Don't run unless terminal is sane.
if (( ${LINES:-0} < 15 || ${COLUMNS:-0} < 72 )); then
  if [[ $1 = -f ]]; then
    print -r "$myname: terminal size too small (less than 72x15)." >&2
  fi
  return 1
fi

[TomJo2000]

Well if a .zshrc exists, we don't run zsh-newuser-install,
so its existence does matter. No?

But yeah you're right, that's probably for upstream to work out.

[TomJo2000]

Oh congrats, you won the commit hash lottery.
four in a row, that's 1 in 65536.

[kenjipuro]

Well if a .zshrc exists, we don't run zsh-newuser-install, so its existence does matter. No?

Yes, but if zsh-newuser-install is being run we are in that situation already (the zsh/newuser module runs it when no start-up files, including .zshrc exist). To clarify, I was suggesting that change in zsh-newuser-install, not in the system zshrc.

But it might not hurt to add a post-install script that notifies users of the terminal size issue.

[gphg]

LGTM. I was work remotely at that time, I didn't notice it.