-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gw v0.10.1 #20796
Gw v0.10.1 #20796
Conversation
Linker cannot find libs. How should these be defined in the build?
|
termux-packages/x11-packages/gw/build.sh Lines 1 to 11 in 224857d
It would have auto-updated if there weren't build issues with the new version. As such a simple version bump and updating the checksum is not going to be enough in this case. From the CI logs, it looks like it is unable to find (most of?) its build time dependencies. aarch64-linux-android-clang++ -fstack-protector-strong -Oz -Wall -std=c++17 -fno-common -fwrapv -fno-omit-frame-pointer -O3 -DNDEBUG -g -D LINUX -D __STDC_FORMAT_MACROS ./src/drawing.o ./src/glfw_keys.o ./src/hts_funcs.o ./src/main.o ./src/menu.o ./src/parser.o ./src/plot_commands.o ./src/plot_controls.o ./src/plot_manager.o ./src/segments.o ./src/term_out.o ./src/themes.o ./src/utils.o ./lib/libBigWig/bwRead.o ./lib/libBigWig/bwValues.o ./lib/libBigWig/bwWrite.o ./lib/libBigWig/io.o -L./lib/skia/out/Release-arm64 -lskia -lm -ljpeg -lpng -lpthread -lX11 -lEGL -lGLESv2 -lhts -lfreetype -luuid -lz -lcurl -licu -ldl -lglfw -lsvg -lfontconfig -o gw
ld.lld: error: unable to find library -lpthread
ld.lld: error: unable to find library -lX11
ld.lld: error: unable to find library -lhts
ld.lld: error: unable to find library -lfreetype
ld.lld: error: unable to find library -luuid
ld.lld: error: unable to find library -lcurl
ld.lld: error: unable to find library -lglfw
ld.lld: error: unable to find library -lfontconfig
clang-17: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:125: gw] Error 1
Error: Process completed with exit code 2. |
Thanks @TomJo2000 |
It looks like there should be something added to LDLIBS or similar, the linker can't find various libs, even though some of them are in the recipe? Does anyone know how to fix this? Thanks! |
Patch the makefiles or use LDFLAGS with |
https://github.com/kcleal/gw/blob/b4f4706ba94fb5b86fb5eca4d9fce68e99e0102e/Makefile#L55 Ah I fail to mention that LDFLAGS already have It's just that the Makefile is clearing out the LDFLAGS, so you have remove that line by patching it. |
We'll still wanna squash these commits. |
x11-packages/gw/build.sh
Outdated
@@ -20,7 +20,7 @@ termux_step_pre_configure() { | |||
sed -i \ | |||
-e '/\/usr\/local\/include/d' \ | |||
-e '/\/usr\/local\/lib/d' \ | |||
./Makefile | |||
./Makefile && sed -i 's/LDFLAGS=/LDFLAGS+=/g' Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged into a single command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has not been resolved
The build error was caused by an overlooked array reference in I'm going to rebase this PR on top of that commit. |
And, we're all green. |
Co-authored-by: tqfx <[email protected]>
No idea what went wrong with the previous CI run, we're all green here now. Package contents check out. |
Co-authored-by: tqfx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just gonna wait out the CI run, and then we can squash this mess. |
Also @kcleal, please consider squashing your commits after rebasing against the master branch. It makes the review process much easier for us. Also thanks for the PR |
I'm fine doing rebases and squashing myself. |
Think that might be our first 3 author commit in the repo lol. |
Thanks, really appreciate the help! |
No description provided.