Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gw v0.10.1 #20796

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Gw v0.10.1 #20796

merged 11 commits into from
Jul 15, 2024

Conversation

kcleal
Copy link
Contributor

@kcleal kcleal commented Jul 8, 2024

No description provided.

@kcleal
Copy link
Contributor Author

kcleal commented Jul 8, 2024

Linker cannot find libs. How should these be defined in the build?

ld.lld: error: unable to find library -lpthread
[2918](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2919)
ld.lld: error: unable to find library -lX11
[2919](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2920)
ld.lld: error: unable to find library -lhts
[2920](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2921)
ld.lld: error: unable to find library -lfreetype
[2921](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2922)
ld.lld: error: unable to find library -luuid
[2922](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2923)
ld.lld: error: unable to find library -lcurl
[2923](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2924)
ld.lld: error: unable to find library -lglfw
[2924](https://github.com/termux/termux-packages/actions/runs/9841341897/job/27167721840?pr=20796#step:8:2925)
ld.lld: error: unable to find library -lfontconfig

@TomJo2000
Copy link
Member

gw has TERMUX_PKG_AUTO_UPDATE set to true.

TERMUX_PKG_HOMEPAGE=https://github.com/kcleal/gw
TERMUX_PKG_DESCRIPTION="A browser for genomic sequencing data (.bam/.cram format)"
TERMUX_PKG_LICENSE="MIT"
TERMUX_PKG_MAINTAINER="[email protected]"
TERMUX_PKG_VERSION=0.9.3
TERMUX_PKG_REVISION=1
TERMUX_PKG_SRCURL=https://github.com/kcleal/gw/archive/v${TERMUX_PKG_VERSION}.tar.gz
TERMUX_PKG_SHA256=43445ef6d96bd8a09a9a45cd18e21481d7fefe7e9ab26aec4abd8d1f4bff3fcd
TERMUX_PKG_DEPENDS="glfw, htslib, libc++, libjpeg-turbo, opengl"
TERMUX_PKG_BUILD_DEPENDS="fontconfig, freetype, libicu, libuuid, mesa-dev"
TERMUX_PKG_AUTO_UPDATE=true

It would have auto-updated if there weren't build issues with the new version.
As such a simple version bump and updating the checksum is not going to be enough in this case.

From the CI logs, it looks like it is unable to find (most of?) its build time dependencies.
And also requires curl as a dependency now.

aarch64-linux-android-clang++  -fstack-protector-strong -Oz -Wall -std=c++17 -fno-common -fwrapv -fno-omit-frame-pointer -O3 -DNDEBUG -g -D LINUX -D __STDC_FORMAT_MACROS  ./src/drawing.o  ./src/glfw_keys.o  ./src/hts_funcs.o  ./src/main.o  ./src/menu.o  ./src/parser.o  ./src/plot_commands.o  ./src/plot_controls.o  ./src/plot_manager.o  ./src/segments.o  ./src/term_out.o  ./src/themes.o  ./src/utils.o  ./lib/libBigWig/bwRead.o  ./lib/libBigWig/bwValues.o  ./lib/libBigWig/bwWrite.o  ./lib/libBigWig/io.o -L./lib/skia/out/Release-arm64 -lskia -lm -ljpeg -lpng -lpthread -lX11 -lEGL -lGLESv2 -lhts -lfreetype -luuid -lz -lcurl -licu -ldl -lglfw -lsvg -lfontconfig -o gw
ld.lld: error: unable to find library -lpthread
ld.lld: error: unable to find library -lX11
ld.lld: error: unable to find library -lhts
ld.lld: error: unable to find library -lfreetype
ld.lld: error: unable to find library -luuid
ld.lld: error: unable to find library -lcurl
ld.lld: error: unable to find library -lglfw
ld.lld: error: unable to find library -lfontconfig
clang-17: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:125: gw] Error 1
Error: Process completed with exit code 2.

@kcleal
Copy link
Contributor Author

kcleal commented Jul 8, 2024

Thanks @TomJo2000
Some of those libs are in the build recipe already, some I think should be on the system already (X11, pthread), so not sure why the linker is failing?

@kcleal
Copy link
Contributor Author

kcleal commented Jul 8, 2024

It looks like there should be something added to LDLIBS or similar, the linker can't find various libs, even though some of them are in the recipe? Does anyone know how to fix this? Thanks!

@truboxl
Copy link
Contributor

truboxl commented Jul 9, 2024

Patch the makefiles or use LDFLAGS with -L${TERMUX_PREFIX}/lib

@truboxl
Copy link
Contributor

truboxl commented Jul 9, 2024

https://github.com/kcleal/gw/blob/b4f4706ba94fb5b86fb5eca4d9fce68e99e0102e/Makefile#L55

Ah I fail to mention that LDFLAGS already have -L${TERMUX_PREFIX}/lib inside our build scripts.

It's just that the Makefile is clearing out the LDFLAGS, so you have remove that line by patching it.

@TomJo2000
Copy link
Member

We'll still wanna squash these commits.
But I can take it from here.

@@ -20,7 +20,7 @@ termux_step_pre_configure() {
sed -i \
-e '/\/usr\/local\/include/d' \
-e '/\/usr\/local\/lib/d' \
./Makefile
./Makefile && sed -i 's/LDFLAGS=/LDFLAGS+=/g' Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged into a single command

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has not been resolved

x11-packages/gw/build.sh Outdated Show resolved Hide resolved
@kcleal kcleal changed the title Gw v0.10.0 Gw v0.10.1 Jul 12, 2024
@TomJo2000
Copy link
Member

The build error was caused by an overlooked array reference in alist's build script.
Fixed it in aa97f6e.

I'm going to rebase this PR on top of that commit.

@TomJo2000
Copy link
Member

And, we're all green.

x11-packages/gw/build.sh Outdated Show resolved Hide resolved
x11-packages/gw/build.sh Outdated Show resolved Hide resolved
x11-packages/gw/build.sh Outdated Show resolved Hide resolved
@TomJo2000
Copy link
Member

No idea what went wrong with the previous CI run, we're all green here now.

Package contents check out.
I think we have all concerns addressed?
I'd like to just get this PR done.

Copy link
Member

@thunder-coding thunder-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomJo2000
Copy link
Member

Just gonna wait out the CI run, and then we can squash this mess.

@thunder-coding
Copy link
Member

Also @kcleal, please consider squashing your commits after rebasing against the master branch. It makes the review process much easier for us. Also thanks for the PR

@TomJo2000
Copy link
Member

I'm fine doing rebases and squashing myself.
I just generally prefer to leave the PR author in control of what exactly is in what commit, and what the commit message(s) are.

@TomJo2000 TomJo2000 merged commit e4f750c into termux:master Jul 15, 2024
5 checks passed
@TomJo2000
Copy link
Member

Think that might be our first 3 author commit in the repo lol.

@kcleal
Copy link
Contributor Author

kcleal commented Jul 15, 2024

Thanks, really appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants