bump(main/dnsutils): 9.20.4 #23013
Open
bump(main/dnsutils): 9.20.4 #23013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MrAdityaAlok
commented
Jan 23, 2025
MrAdityaAlok
commented
- bump(main/dnsutils): 9.20.4
- addpkg(main): liburcu
MrAdityaAlok
force-pushed
the
update-dnsutils
branch
4 times, most recently
from
10b439e to
4d6f0fe
Compare
Signed-off-by: Aditya Alok <[email protected]>
- Required by `dnsutils` since version 9.20.4 Signed-off-by: Aditya Alok <[email protected]>
MrAdityaAlok
force-pushed
the
update-dnsutils
branch
from
4d6f0fe to
74c3153
Compare
|
@Grimler91 Please review. |
Grimler91
reviewed
Jan 24, 2025
| make -C bin/nsupdate install | ||
| termux_step_post_configure() { | ||
| # Android linker is unable to driectly reslove versoined libraries. | ||
| # This will create a symlink to versoined library via `libname.so`. |
There was a problem hiding this comment.
nit: typos, you type too fast I guess :D
driectly -> directly
reslove -> resolve
versoined -> versioned (in two places)
| termux_step_post_configure() { | ||
| # Android linker is unable to driectly reslove versoined libraries. | ||
| # This will create a symlink to versoined library via `libname.so`. | ||
| sed -i 's|library_names_spec=.*|library_names_spec="\\\$libname\\\$release\\\$shared_ext \\\$libname\\\$shared_ext"|g' ./libtool |
There was a problem hiding this comment.
Hmm, why is this needed? The linuxandroid case in libtool.m4 already contains exactly this spec:
linux*android*)
version_type=none # Android doesn't support versioned libraries.
need_lib_prefix=no
need_version=no
library_names_spec='$libname$release$shared_ext $libname$shared_ext'
is it matching and using another case?
There was a problem hiding this comment.
Weird....
I do not have ($libname$shared_ext) in library_names_spec locally.
Which version did you check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.