fix: annotate the proper amino names on the proto messages #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrezaz
changed the title
|
Thanks for the PR @madrezaz, very well seen! Will it be relevant to add the amino names for the governance proposals? |
|
@emidev98 Well I'm not sure about this as these are legacy proposals, but considering cosmos-sdk as example, I think it's not needed. |
emidev98
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Perfect! Thanks for the PR, I'll be waiting for @javiersuweijie review and we'll be good to merge and release a new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, generated clients use default message name as the message's amino name as there is no
amino.nameannotation on the proto messages. This PR intends to add the amino names registered on amino codecs to the proto.