Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Added import table feature and AWS provider v5 upgrade #77

Merged
merged 8 commits into from
Oct 27, 2023
Merged

feat!: Added import table feature and AWS provider v5 upgrade #77

merged 8 commits into from
Oct 27, 2023

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Oct 26, 2023 •
edited
Loading

Description

Adds import_table functionality.

Motivation and Context

hashicorp/terraform-provider-aws#27253
hashicorp/terraform-provider-aws#33802

Breaking Changes

Yes, AWS provider version v5 upgrade.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum changed the title feat: Import table feat: Import table and provider v5 upgrade Oct 26, 2023
@antonbabenko antonbabenko changed the title feat: Import table and provider v5 upgrade feat!: Added import table feature and AWS provider v5 upgrade Oct 27, 2023
antonbabenko
antonbabenko reviewed Oct 27, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
antonbabenko
antonbabenko approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and LGTM

main.tf Show resolved Hide resolved
antonbabenko
antonbabenko requested changes Oct 27, 2023
View reviewed changes
main.tf Show resolved Hide resolved
@antonbabenko
Copy link
Member

Please update the examples section in the root README.md and rename examples/s3_import to examples/s3-import (like we have in most other recent terraform-aws-modules.

@antonbabenko antonbabenko merged commit d596c25 into terraform-aws-modules:master Oct 27, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 27, 2023
@semantic-release-bot
chore(release): version 4.0.0 [skip ci]
715399d 
## [4.0.0](v3.3.0...v4.0.0) (2023-10-27)

### ⚠ BREAKING CHANGES

* Added import table feature and AWS provider v5 upgrade (#77)

### Features

* Added import table feature and AWS provider v5 upgrade ([#77](#77)) ([d596c25](d596c25))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@magreenbaum magreenbaum deleted the feat/import_table branch October 27, 2023 15:43
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magreenbaum @antonbabenko