OCM-4442: Moved kmsARN regexp validator to common lib #334
Conversation
|
Hi @den-rgb. Thanks for your PR. I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sagidayan
changed the title
|
@den-rgb: This pull request references OCM-3155 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@den-rgb: This pull request references OCM-3155 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@den-rgb please rebase your branch to include latest CI changes due to tf1.6.0 breaking changes. Also before pushing, run |
I need to wait for ocm-common changes to be merged first before I can continue with this |
|
@den-rgb thank you for this contribution |
|
@den-rgb: This pull request references OCM-3155 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
den-rgb
force-pushed
the
OCM-3155
branch
5 times, most recently
from
a38d5e1 to
af0c2e4
Compare
|
@den-rgb: This pull request references OCM-3155 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
den-rgb
changed the title
|
@den-rgb: This pull request references OCM-4442 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
den-rgb
force-pushed
the
OCM-3155
branch
2 times, most recently
from
3656846 to
d471620
Compare
|
/hold cancel |
|
/approve |
|
/lgtm |
|
Could someone point me to how to resolve these errors as they don't seem to be related to my changes, Thanks |
|
can you rebace on the main branch |
|
/approve Thanks @den-rgb 👏🏽 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sagidayan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
moved kms Arn regexp validator to common lib
Related to : openshift-online/ocm-common#13
JIRA: https://issues.redhat.com/browse/OCM-3155, https://issues.redhat.com/browse/OCM-4442