Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated to allow iam role for creator arn #824

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

vamsinm
Copy link
Contributor

@vamsinm vamsinm commented Oct 16, 2024

What this PR does / why we need it: updated to allow iam role arn for creator arn

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): #823
Fixes #

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign osherdp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 16, 2024

Hi @vamsinm. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seanmalloy
Copy link

Jira ticket: OCM-11994

@gdbranco
Copy link
Contributor

Hello there @vamsinm could you edit the commit title to be OCM-11994 | fix: updated to allow iam role for creator arn ? That should make it pass the validation so we can proceed with the tests for this

@gdbranco gdbranco merged commit c54981d into terraform-redhat:main Oct 23, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants