Simplify ControlFlowGraph.Build.
#172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By definition, only the last instruction of a basic block can branch. As a result, when building the control flow graph, there is no need to inspect every instruction of a basic block.
By definition, a label can be located only at the start of a basic block. As a result, when building the control flow graph, there is no need to check whether every instruction is of type `BoundLabelStatement`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By definition, only the last instruction of a basic block can branch.
As a result, when building the control flow graph, there is no need to inspect every instruction of a basic block.
And a label can be located only at the start of a basic block.
As a result, there is no need to check whether every instruction is of type
BoundLabelStatement.Lastly, the field
_blockFromStatementis not used when building a control flow graph. Let's remove it?