Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not deduct tax in ibc token #16

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

JoowonYun
Copy link
Member

@JoowonYun JoowonYun commented Oct 30, 2023

Summary of changes

The policy has been changed to not deduct tax for IBC tokens.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Added a relevant changelog entry to CHANGELOG.md

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #16 (dd35a13) into main (7839ad1) will decrease coverage by 0.18%.
The diff coverage is 74.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   89.01%   88.83%   -0.18%     
==========================================
  Files          19       19              
  Lines        3668     3699      +31     
==========================================
+ Hits         3265     3286      +21     
- Misses        403      413      +10     
Files Coverage Δ
contracts/terraswap_pair/src/contract.rs 93.78% <ø> (+0.04%) ⬆️
packages/classic_terraswap/src/testing.rs 100.00% <100.00%> (ø)
contracts/terraswap_router/src/contract.rs 84.71% <0.00%> (-0.14%) ⬇️
contracts/terraswap_router/src/querier.rs 90.47% <50.00%> (-9.53%) ⬇️
packages/classic_terraswap/src/asset.rs 93.58% <83.33%> (-0.94%) ⬇️
packages/classic_terraswap/src/mock_querier.rs 87.90% <33.33%> (+1.05%) ⬆️

... and 7 files with indirect coverage changes

jbamlee
jbamlee previously approved these changes Oct 31, 2023
Copy link

@jbamlee jbamlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question.
Does IBC token have only A-F characters?

packages/classic_terraswap/src/asset.rs Outdated Show resolved Hide resolved
@JoowonYun
Copy link
Member Author

Question. Does IBC token have only A-F characters?

IBC hash is SHA256. So, it is a 64-digit hexadecimal hex value.

@JoowonYun JoowonYun merged commit d3f09ea into main Oct 31, 2023
4 checks passed
@JoowonYun JoowonYun deleted the feature/tax-ibc-token branch October 31, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants