Tests for m2e-core PR 303 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing modules to the root pom and the downloadsources-aggregator pom. If you run the Maven deployment to the testrepo from the root of testrepo-src the entire repo is re-build and not only some modules. Update the compiler source/target to 1.6 because those seem to be the minimal possible levels with a JDK-11. And fix the maven-deploy-plugin version because Maven 3.8.1 uses the deploy-plugin in version 3.0.0-M1 which has breaking changes in its altDeploymentRepository property (and some projects seem to use always the old version regardless what is specified in the parent-pom's pluginManagement. Moving it to deploy-plugin >=3.0.0 would require more changes). The specification of the compiler's target and source level have to be changed in 549312-fallbackToLatestEE/pom.xml because the maven.compiler.source property seem not to override the value from the parents pluginManagement section. With those changes the build of the test repo now completes (nevertheless there are some errors printed, mainly because of missing checksums)
+ Add an downloadsources case 9, a SNAPSHOT version to the testrepo. + Add a downloadsources project No. 9 that uses the new snapshot version artifact. + Add tests for m2e-core issue #252
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in PR eclipse-m2e/m2e-core#303 I have created tests for issue eclipse-m2e/m2e-core#252, especially the situation addressed by PR 303.
Besides that I cleaned-up/unified the BuildPathManagerTest and the creation of the testrepo.
The test repo build was updated to build/deploy all modules and not only a few of them (the selection seemed random to me) and to complete successfully with a current JDK-11.
Please see the corresponding commit messages for more details.
@mickaelistria or @akurtakov can you review and merge this please?