Clean up dead code in topic enforcer around listing existing topics. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic Enforcer lists existing topics with an optional filter to exclude internal topics from enforcement. It was intended to be a switch to allow including internal topics in the results. However, we have never included internal topics for the enforcer, and the current listing code does not work for that logic either -- even if we include internal topics in the Kafka admin client call, the internal topics are still filtered out at the step when we returns.
Given we are not using this include-internal logic, let's just remove it and clean up.