Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dead code in topic enforcer around listing existing topics. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shk3
Copy link
Contributor

@shk3 shk3 commented Dec 27, 2024

Topic Enforcer lists existing topics with an optional filter to exclude internal topics from enforcement. It was intended to be a switch to allow including internal topics in the results. However, we have never included internal topics for the enforcer, and the current listing code does not work for that logic either -- even if we include internal topics in the Kafka admin client call, the internal topics are still filtered out at the step when we returns.

Given we are not using this include-internal logic, let's just remove it and clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants