Skip to content

Commit

Permalink
Fix regression in session info
Browse files Browse the repository at this point in the history
Commit beb8735 introduced a
regression that prevents clients from establishing session info on
connections that are not cached. It caused a handshake to one domain to
be cancelled when a handshake to another domain succeeded.
  • Loading branch information
Seth Terashima committed Jan 18, 2024
1 parent beb8735 commit 9843bd4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/dispatcher/dispatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (d *Dispatcher) StartSessions(ctx context.Context, domains []universal.Doma
err = <-results
// The aggregateContext is canceled if one of the handshakes fails. We don't want to return
// the Canceled error if ErrProtocolNotSupported is present.
if !errors.Is(err, context.Canceled) {
if err != nil && !errors.Is(err, context.Canceled) {
return err
}
}
Expand Down

0 comments on commit 9843bd4

Please sign in to comment.