Spelling fixes #96
Merged
Spelling fixes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Recieve" -> "Receive". D'oh! The pkg/connector/ble/ble.go method had both Receive and Recieve methods. Deleting the latter is an API-breaking change, but such changes should be expected in v0.x.x according to Go semantic versioning standards.
sethterashima
commented
Dec 9, 2023
| @@ -112,10 +112,6 @@ func (c *Connection) Send(ctx context.Context, buffer []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *Connection) Recieve() <-chan []byte { | |||
There was a problem hiding this comment.
There is already a Receive method.
agbpatro
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Recieve" -> "Receive". D'oh!
The pkg/connector/ble/ble.go method had both Receive and Recieve methods. Deleting the latter is an API-breaking change, but such changes should be expected in v0.x.x according to Go semantic versioning standards.
Fixes #60
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: