Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows unit test failing in gitlab pipeline #130

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

ByronAmbright
Copy link

@ByronAmbright ByronAmbright commented Nov 8, 2019

  • This issue should be resolved when version 1.8.7 of the electron rebuild
    npm package gets released.
  • Remove package-lock.json from the gitignore
  • Seperate test yaml for each platform into different files

@ByronAmbright ByronAmbright force-pushed the Fix_azure_pipeline_issue branch 22 times, most recently from a3e2f9a to 60bd99b Compare November 10, 2019 20:07
* This issue should be resolved when version 1.8.7 of the electron rebuild
npm package gets released.
* Remove package-lock.json from the gitignore
* Seperate test yaml for each platform into different files
Copy link
Collaborator

@theeldestelder theeldestelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Dumb that we have to wait for a new electron build to finish to actually resolve this, but whatever.

@theeldestelder
Copy link
Collaborator

See #132 as the issue tracking the uncommenting of these unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants