Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit smarter cursor position (DRY version) #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamntz
Copy link

@iamntz iamntz commented Jul 13, 2015

see #9

@bogdananton
Copy link
Member

Hi and thank you, I think the run_command is a nice improvement, but I'm having issues with multiple cursors.

I'm thinking: sandboxing the run_command for each cursor or adjusting the cursor after each insert.

@iamntz
Copy link
Author

iamntz commented Jul 15, 2015

Mmm, you're right. But I assume generating multiple tests at once is less common than the need of having the cursor placed in the right place :)

bogdananton added a commit that referenced this pull request Jul 15, 2015
@todo fix cursor position for Jasmine tests.
@todo replace string replace with run_command (#10)
@bogdananton
Copy link
Member

For now I've made a temporary fix by adjusting the cursor; will revert and merge your fix when used in caret isolation (I've made some attempts using temporary regions but with no success so far).

In my workflow, I first define specs/phrases and generate their test methods at the same time. Also, sometimes I'm replacing a term in existing test doc blocks and want to update them at the same time without going in each test method instance and using the shortcut.

The other plugins (Eclipse and PHPStorm) add markTestIncomplete as the default method body. (ST version has some catching up to do, but after getting a proper virtual environment to test this plugin).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants