chore: include common CMD used across all libraries #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
requested review from
cristianrgreco,
eddumelendez,
HofmeisterAn and
kiview
HofmeisterAn
approved these changes
Apr 23, 2024
bsideup
approved these changes
Apr 23, 2024
|
I've tested this Dockerfile while working on testcontainers/testcontainers-go#2471, building the image with Once merged and released a new version, I'll update the PR to use 1.2.0, and will eventually submit PRs to all the tc-langs. |
mdelapenya
added a commit
to testcontainers/testcontainers-java
that referenced
this pull request
Apr 24, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the CMD command that is used in testcontainers-java, dotnet testcontainers-node or testcontainers-go
Why is it important?
Reduce duplication across projects, building the image with the same CMD command for all.
Follow-ups
Update the projects to consume the newest image, removing the custom CMD.