adding psycog binary/pool; fixing PostgresContainer field names #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I couldn't find any contributor guidelines, so let me know if this doesn't conform to style or if PRs aren't accepted.
I was recently following this guide: https://testcontainers.com/guides/getting-started-with-testcontainers-for-python/ and ran into two issues.
For #1, it seems that on a M2 mac you need to explicitly install the binary and pool components of psycog. I'm not sure if this is something specific to M2 macs, but thought it might be helpful to update the requirements.txt file.
For #2, the field names for the PostgresContainer seem to have been renamed. I'm not sure if this is specific to the version of TestContainers that's installed or something else.
This PR also adds an entry in .gitignore for pycache/ which I thought would be generally useful.
Thanks for reviewing my PR. Let me know how I can improve it and I'll be happy to do so.