chore: Remove PulsarContainer.CreateAuthenticationTokenAsync(TimeSpan…

…) default arg (#1195) Co-authored-by: David Jensen <[email protected]>
testcontainers · Jun 13, 2024 · b5c926a · b5c926a
1 parent 56d3eab
commit b5c926a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 21 deletions.
diff --git a/docs/modules/pulsar.md b/docs/modules/pulsar.md
@@ -92,13 +92,20 @@ If you need to use token authentication, use the following builder configuration
 PulsarContainer _pulsarContainer = PulsarBuilder().WithTokenAuthentication().Build();
 ```
 
-Start the container and get the token from the running instance by using:
+Start the container and obtain an authentication token with a specified expiration time
 
 ```csharp
 var authToken = await container.CreateAuthenticationTokenAsync(TimeSpan.FromHours(1))
     .ConfigureAwait(false);
 ```
 
+Alternatively, set the token to never expire
+
+```csharp
+var authToken = await container.CreateAuthenticationTokenAsync(Timeout.InfiniteTimeSpan)
+    .ConfigureAwait(false);
+```
+
 ## Enable Pulsar Functions
 
 If you need to use Pulsar Functions, use the following builder configuration to enable it:

diff --git a/src/Testcontainers.Pulsar/PulsarContainer.cs b/src/Testcontainers.Pulsar/PulsarContainer.cs
@@ -37,42 +37,44 @@ public string GetServiceAddress()
     /// <summary>
     /// Creates an authentication token.
     /// </summary>
-    /// <param name="expire">The time after the authentication token expires.</param>
+    /// <param name="expiryTime">The time after the authentication token expires.</param>
     /// <param name="ct">Cancellation token.</param>
     /// <returns>A task that completes when the authentication token has been created.</returns>
     /// <exception cref="ArgumentException"></exception>
-    public async Task<string> CreateAuthenticationTokenAsync(TimeSpan expire = default, CancellationToken ct = default)
+    public async Task<string> CreateAuthenticationTokenAsync(TimeSpan expiryTime, CancellationToken ct = default)
     {
-        int secondsToMilliseconds;
-
         if (_configuration.AuthenticationEnabled.HasValue && !_configuration.AuthenticationEnabled.Value)
         {
             throw new ArgumentException("Failed to create token. Authentication is not enabled.");
         }
-
-        if (_configuration.Image.Tag.StartsWith("3.2") || _configuration.Image.Tag.StartsWith("latest"))
-        {
-            Logger.LogWarning("The 'apachepulsar/pulsar:3.2.?' image contains a regression. The expiry time is converted to the wrong unit of time: https://github.com/apache/pulsar/issues/22811.");
-            secondsToMilliseconds = 1000;
-        }
-        else
-        {
-            secondsToMilliseconds = 1;
-        }
-
-        var command = new[]
+
+        var command = new List<string>(9)
         {
             "bin/pulsar",
             "tokens",
             "create",
             "--secret-key",
             PulsarBuilder.SecretKeyFilePath,
             "--subject",
-            PulsarBuilder.Username,
-            "--expiry-time",
-            $"{secondsToMilliseconds * expire.TotalSeconds}s",
+            PulsarBuilder.Username
         };
 
+        if (expiryTime != Timeout.InfiniteTimeSpan)
+        {
+            int secondsToMilliseconds;
+            if (_configuration.Image.Tag.StartsWith("3.2") || _configuration.Image.Tag.StartsWith("latest"))
+            {
+                Logger.LogWarning("The 'apachepulsar/pulsar:3.2.?' image contains a regression. The expiry time is converted to the wrong unit of time: https://github.com/apache/pulsar/issues/22811.");
+                secondsToMilliseconds = 1000;
+            }
+            else
+            {
+                secondsToMilliseconds = 1;
+            }
+            command.Add("--expiry-time");
+            command.Add($"{secondsToMilliseconds * expiryTime.TotalSeconds}s");
+        }
+
         var tokensResult = await ExecAsync(command, ct)
             .ConfigureAwait(false);
 

diff --git a/tests/Testcontainers.Pulsar.Tests/PulsarContainerTest.cs b/tests/Testcontainers.Pulsar.Tests/PulsarContainerTest.cs
@@ -79,7 +79,7 @@ public PulsarAuthConfiguration()
 
         protected override async Task<IPulsarClient> CreateClientAsync(CancellationToken ct = default)
         {
-            var authToken = await _pulsarContainer.CreateAuthenticationTokenAsync(TimeSpan.FromHours(1), ct)
+            var authToken = await _pulsarContainer.CreateAuthenticationTokenAsync(Timeout.InfiniteTimeSpan, ct)
                 .ConfigureAwait(false);
 
             return PulsarClient.Builder().ServiceUrl(new Uri(_pulsarContainer.GetBrokerAddress())).Authentication(new TokenAuthentication(authToken)).Build();