Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Consul module #1028

Merged
merged 9 commits into from
Oct 21, 2023
Merged

feat: Add Consul module #1028

merged 9 commits into from
Oct 21, 2023

Conversation

witskeeper
Copy link
Contributor

What does this PR do?

add Testcontainers.Consul

Why is it important?

support consul containers

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit e4a7ef2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/653400bde737d1000785ab93
😎 Deploy Preview https://deploy-preview-1028--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HofmeisterAn
HofmeisterAn requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and the pull request. Overall, it looks good. I do have a few minor suggestions and changes that we need to address before we can merge it. Thanks again.

Testcontainers.sln Outdated Show resolved Hide resolved
src/Testcontainers.Consul/ConsulBuilder.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Consul.Tests/ConsulContainerTest.cs Outdated Show resolved Hide resolved
src/Testcontainers.Consul/ConsulContainer.cs Outdated Show resolved Hide resolved
@HofmeisterAn
Copy link
Collaborator

Thank you for addressing the suggestions. I have briefly reviewed the PR, and it looks good. I plan to merge it either tomorrow or the day after, depending on my availability.

@witskeeper
Copy link
Contributor Author

glad to be able to contribute code.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Oct 21, 2023
@HofmeisterAn HofmeisterAn changed the title add Testcontainers.Consul feat: Add Consul module Oct 21, 2023
@HofmeisterAn HofmeisterAn merged commit aa4385d into testcontainers:develop Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witskeeper @HofmeisterAn