Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load PKCS#12 correctly for mTLS on Windows in .NET 9 #1320

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jvmdc
Copy link
Contributor

@jvmdc jvmdc commented Dec 20, 2024

What does this PR do?

Fixes loading of PKCS12 for mTLS on WIndows in .NET 9

As documented at https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0057#workaround, LoadCertificate does not support PKCS12. PFX files are PKCS12 these days.

Why is it important?

Currently mTLS is broken for Windows in .NET 9

Related issues

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 732b595
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67654a661a711500092d429a
😎 Deploy Preview https://deploy-preview-1320--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Dec 27, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@HofmeisterAn HofmeisterAn changed the title fix: Load PKCS12 correctly for mTLS on Windows in .NET 9 fix: Load PKCS#12 correctly for mTLS on Windows in .NET 9 Dec 27, 2024
@HofmeisterAn HofmeisterAn merged commit 48d16b6 into testcontainers:develop Dec 27, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mutual TLS on Windows in .NET 9 does not work
2 participants