Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for missing rootless support #147

Merged
merged 1 commit into from
Nov 10, 2024
Merged

fix for missing rootless support #147

merged 1 commit into from
Nov 10, 2024

Conversation

jarlah
Copy link
Member

@jarlah jarlah commented Nov 10, 2024

fixes #146 and maybe #73

this might be is a very a "hacky" fix, and needs review

A problem is lack of Windows support. But its possible to use testcontainers desktop. Not tested ofc

@jarlah jarlah changed the title wip: temp fix for rootless support fix for missing rootless support Nov 10, 2024
@jarlah
Copy link
Member Author

jarlah commented Nov 10, 2024

this works now in my rootless docker setup in nixos plus github actions. So there is more functionality than before. I will also test old root based docker. But it should work same

@jarlah jarlah force-pushed the fix_rootless_support branch from 56fa41d to f200359 Compare November 10, 2024 17:57
@jarlah
Copy link
Member Author

jarlah commented Nov 10, 2024

yes it works with normal root based docker :) stampy stamp

@jarlah jarlah merged commit 2ffbe33 into main Nov 10, 2024
7 checks passed
@jarlah jarlah deleted the fix_rootless_support branch November 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootless support in general ...
1 participant