Merge pull request #62 from appleboy/patch

support timeout for NewLogStrategy

docker_test.go

@@ -328,6 +328,27 @@ func TestContainerCreationTimesOutWithHttp(t *testing.T) {
 	}
 }
 
+func TestContainerCreationWaitsForLogContextTimeout(t *testing.T) {
+	ctx := context.Background()
+	req := ContainerRequest{
+		Image:        "mysql:latest",
+		ExposedPorts: []string{"3306/tcp", "33060/tcp"},
+		Env: map[string]string{
+			"MYSQL_ROOT_PASSWORD": "password",
+			"MYSQL_DATABASE":      "database",
+		},
+		WaitingFor: wait.ForLog("test context timeout").WithStartupTimeout(1 * time.Second),
+	}
+	_, err := GenericContainer(ctx, GenericContainerRequest{
+		ContainerRequest: req,
+		Started:          true,
+	})
+
+	if err == nil {
+		t.Error("Expected timeout")
+	}
+}
+
 func TestContainerCreationWaitsForLog(t *testing.T) {
 	ctx := context.Background()
 	req := ContainerRequest{

wait/log.go

@@ -62,19 +62,26 @@ func (ws *LogStrategy) WaitUntilReady(ctx context.Context, target StrategyTarget
 	ctx, cancelContext := context.WithTimeout(ctx, ws.startupTimeout)
 	defer cancelContext()
 
+LOOP:
 	for {
-		reader, err := target.Logs(ctx)
-		if err != nil {
-			time.Sleep(ws.PollInterval)
-			continue
-		}
-		b, err := ioutil.ReadAll(reader)
-		logs := string(b)
-		if strings.Contains(logs, ws.Log) {
-			break
-		} else {
-			time.Sleep(ws.PollInterval)
-			continue
+		select {
+		case <-ctx.Done():
+			return ctx.Err()
+		default:
+			reader, err := target.Logs(ctx)
+
+			if err != nil {
+				time.Sleep(ws.PollInterval)
+				continue
+			}
+			b, err := ioutil.ReadAll(reader)
+			logs := string(b)
+			if strings.Contains(logs, ws.Log) {
+				break LOOP
+			} else {
+				time.Sleep(ws.PollInterval)
+				continue
+			}
 		}
 	}