Merge pull request #354 from Lucaber/fix/mount-map

Swap incorrect key and value of BindMounts and VolumeMounts
testcontainers · Nov 19, 2021 · 1517941 · 1517941
2 parents 3e32ca0 + 3eed4e2
commit 1517941
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docker.go b/docker.go
@@ -743,14 +743,14 @@ func (p *DockerProvider) CreateContainer(ctx context.Context, req ContainerReque
 
 	// prepare mounts
 	mounts := []mount.Mount{}
-	for hostPath, innerPath := range req.BindMounts {
+	for innerPath, hostPath := range req.BindMounts {
 		mounts = append(mounts, mount.Mount{
 			Type:   mount.TypeBind,
 			Source: hostPath,
 			Target: innerPath,
 		})
 	}
-	for volumeName, innerPath := range req.VolumeMounts {
+	for innerPath, volumeName := range req.VolumeMounts {
 		mounts = append(mounts, mount.Mount{
 			Type:   mount.TypeVolume,
 			Source: volumeName,

diff --git a/docker_test.go b/docker_test.go
@@ -1404,8 +1404,8 @@ func TestContainerCreationWithBindAndVolume(t *testing.T) {
 	bashC, err := GenericContainer(ctx, GenericContainerRequest{
 		ContainerRequest: ContainerRequest{
 			Image:        "bash",
-			BindMounts:   map[string]string{absPath: "/hello.sh"},
-			VolumeMounts: map[string]string{volumeName: "/data"},
+			BindMounts:   map[string]string{"/hello.sh": absPath},
+			VolumeMounts: map[string]string{"/data": volumeName},
 			Cmd:          []string{"bash", "/hello.sh"},
 			WaitingFor:   wait.ForLog("done"),
 		},