fix(compose): race condition (#2842)

Fix a race condition in compose module when setting up multiple containers.
testcontainers · Oct 21, 2024 · e945309 · e945309
1 parent 5a4eec1
commit e945309
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/modules/compose/compose_api.go b/modules/compose/compose_api.go
@@ -379,6 +379,7 @@ func (d *dockerCompose) Up(ctx context.Context, opts ...StackUpOption) (err erro
 
 	// Lookup the containers for each service and connect them
 	// to the reaper if needed.
+	var termSignalsMtx sync.Mutex
 	for _, srv := range d.project.Services {
 		srv := srv
 		errGrpContainers.Go(func() error {
@@ -394,6 +395,9 @@ func (d *dockerCompose) Up(ctx context.Context, opts ...StackUpOption) (err erro
 				}
 
 				dc.SetTerminationSignal(termSignal)
+
+				termSignalsMtx.Lock()
+				defer termSignalsMtx.Unlock()
 				termSignals = append(termSignals, termSignal)
 			}