fix: config via environment

[stevenh]

Fix the ability to set the configuration of testcontainers using an environment variable set by a caller before the use of testcontainers.

This removes the warning about disabling the reaper which is actually safe when done correctly.

Also optimise verbose check while there.

Fixes: #2701 #2636 #2609

[netlify]

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	da4d087
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/66bf352377a26500080a928f
😎 Deploy Preview	https://deploy-preview-2725--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mdelapenya]

@stevenh we probably want to still log the message but not that early. I naively added it to the init method without considering the impact for users not being able to set the logger at the right time.

The current requirements for this would be:

• allow users set their logger. At the moment, each container request supports passing a logger, otherwise, the default one will be used.
• log the Ryuk-disabled message, using user's logger.

For a follow-up redesign (v1) we probably want to include the logger as part of the setup (see your comment in #2701 (comment))

[stevenh]

@stevenh we probably want to still log the message but not that early. I naively added it to the init method without considering the impact for users not being able to set the logger at the right time.

The current requirements for this would be:

• allow users set their logger. At the moment, each container request supports passing a logger, otherwise, the default one will be used.
• log the Ryuk-disabled message, using user's logger.

For a follow-up redesign (v1) we probably want to include the logger as part of the setup (see your comment in #2701 (comment))

I'd actually push back on that and suggest we don't log, here's why:

If someone has chosen to disable the reaper it will be a very conscious decision, and in doing so they are actively taking responsibility. While the user can't protect against leaked resources for a test timeout, that's the only case and we can document that and the extra noise makes it harder to see issues when they occur.

So to help unblock, until we can revisit for v1, I've pushed an update which improves the pkgsite docs, does that work?

[mdelapenya]

If someone has chosen to disable the reaper it will be a very conscious decision

Indeed. Let's do as you propose here without the log. I know we have commented this internally, @kiview, and we want to log the message not using STDOUT but a user-defined logger. Let's keep this in mind for v1.

[mdelapenya]

I've pushed an update which improves the pkgsite docs, does that work?

Not only the pkgsite docs but the docs site: https://deploy-preview-2725--testcontainers-go.netlify.app/features/configuration/ 👏