Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip-host-cache option removed in latest MySQL 8.3.0 version #2130

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Jan 20, 2024

What does this PR do?

It updates how the skip-host-cache config is used, as it's been removed in 8.3.

As described in testcontainers/testcontainers-java#8131:

This change replaces with host_cache_size = 0 which is equivalent and backward compatible back through previous releases (incl 5.7 and even 5.6).

Why is it important?

Fixes MySQL tests

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner January 20, 2024 04:38
@mdelapenya mdelapenya added the bug An issue with the library label Jan 20, 2024
@mdelapenya mdelapenya self-assigned this Jan 20, 2024
Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit b469f9f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65aea6966e92a500088e80f6
😎 Deploy Preview https://deploy-preview-2130--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit b5b7c86 into testcontainers:main Jan 22, 2024
120 checks passed
@mdelapenya mdelapenya deleted the fix-mysql-8 branch January 24, 2024 10:43
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jan 24, 2024
* main: (25 commits)
  chore(deps): bump github.com/dvsekhvalnov/jose2go in /modules/pulsar (testcontainers#2136)
  fix: skip-host-cache option removed in latest MySQL 8.3.0 version (testcontainers#2130)
  chore: skip assertions for Docker Rootless (testcontainers#2135)
  pin Docker images version (testcontainers#2129)
  enable golangci-lint for examples (testcontainers#2128)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#2098)
  enable golangci-lint for redis module (testcontainers#2126)
  Go install gotestsum and golangci-lint  (testcontainers#2127)
  improve OSSF score (testcontainers#2125)
  chore: run make lint on new modules (testcontainers#2122)
  enable golangci-lint for pulsar (testcontainers#2121)
  lint: enable testifylint (testcontainers#2120)
  chore(deps): bump github.com/nats-io/nats.go in /modules/nats (testcontainers#2094)
  chore(deps): bump golang.org/x/sys from 0.15.0 to 0.16.0 (testcontainers#2104)
  Revert "chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (testcontainers#2088)"
  chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (testcontainers#2088)
  chore(deps): bump cloud.google.com/go/spanner from 1.54.0 to 1.55.0, google.golang.org/api from 0.154.0 to 0.156.0 in /modules/gcloud (testcontainers#2115)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.25.10 to 1.26.3, github.com/aws/aws-sdk-go from 1.48.13 to 1.49.19 in /modules/localstack (testcontainers#2114)
  chore(deps): bump github.com/docker/go-connections from 0.4.0 to 0.5.0 (testcontainers#2113)
  Adding mockserver module (testcontainers#2085)
  ...
mdelapenya added a commit to tateexon/testcontainers-go that referenced this pull request Jan 29, 2024
* main: (74 commits)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  chore(deps): bump google.golang.org/api from 0.156.0 to 0.159.0, google.golang.org/grpc from 1.60.1 to 1.61.0, cloud.google.com/go/pubsub from 1.33.0 to 1.35.0 in /modules/gcloud (testcontainers#2168)
  chore(deps): bump github.com/hashicorp/consul/api in /examples/consul (testcontainers#2152)
  chore(deps): bump github.com/couchbase/gocb/v2 in /modules/couchbase (testcontainers#2145)
  chore(deps): bump k8s.io/api, k8s.io/apimachinery and k8s.io/client-go from 0.29.0 to 0.29.1 in /modules/k3s (testcontainers#2167)
  chore: do not compile modules on macos workers on GH (testcontainers#2164)
  Openldap module support (testcontainers#2117)
  Adding inbucket module (testcontainers#2142)
  testifylint: enable compares rule (testcontainers#2143)
  Bump containerd version to v1.7.12 (testcontainers#2137)
  feat: Add Minio module (testcontainers#2132)
  Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073)
  chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141)
  chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096)
  chore(deps): bump github.com/dvsekhvalnov/jose2go in /modules/pulsar (testcontainers#2136)
  fix: skip-host-cache option removed in latest MySQL 8.3.0 version (testcontainers#2130)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant