-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log retried errors #2613
Log retried errors #2613
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5e02f4e
to
988d165
Compare
Could you please update this PR with the changes in #2606 🙏 Thanks! |
988d165
to
e00d678
Compare
Rebased |
Tests are failing with:
|
I'm sorry but I do not see the changes for the lifecycle.go function, adding a retry for checking all exposed ports are already available. |
Hm, I've just checked and I think all commits are there:
Am I missing something? |
Oh sorry, I probably did not explain myself very well. I asked you to check (and update if neeeded) the retry added in #2606, to include the RetryNotify pattern this PR introduces 🙏 |
e00d678
to
0bedcc0
Compare
Ah, ok. Done! |
0bedcc0
to
e6538c7
Compare
e6538c7
to
a400ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* main: fix: log output after context timeout (#2643) chore(deps): use "github.com/containerd/platforms" instead (#2638) chore(deps): bump google.golang.org/grpc to 1.64.1 (#2635) chore(deps): bump certifi from 2024.2.2 to 2024.7.4 (#2631) chore: prepare for next minor development cycle (0.33.0) chore: use new version (v0.32.0) in modules and examples feat: honour go toolchain's verbose flag to print out logs (#2624) Fix issues in BuildImage() (#2626) docs: indicate version for the Run function (#2627) chore: remove duplicated tests for config (#2628) Log retried errors (#2613)
What does this PR do?
Add logging of errors that are retried.
Why is it important?
I want to see any unexpected errors when they happen. Otherwise nothing is logged and the test appears to be stuck forever.
Related issues