fix(redis): port race #2694
Closed
fix(redis): port race #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix race condition on port availability by switching to port instead of log check.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Aug 7, 2024
| @@ -54,7 +54,7 @@ func Run(ctx context.Context, img string, opts ...testcontainers.ContainerCustom | |||
| req := testcontainers.ContainerRequest{ | |||
| Image: img, | |||
| ExposedPorts: []string{"6379/tcp"}, | |||
| WaitingFor: wait.ForLog("* Ready to accept connections"), | |||
| WaitingFor: wait.ForListeningPort("6379/tcp"), | |||
There was a problem hiding this comment.
I haven't seen any issue with this wait strategy, which is widely use here and in the java module.
Could you bring more light about the motivation for the change?
There was a problem hiding this comment.
With all the iterations on the test suite I've had a few cases where test failed due to redis not accept incoming requests.
I didn't dig in fully as with this change, I never saw a reoccurrence. It could be redis reports the log entry early?
There was a problem hiding this comment.
Sure will keep an eye for a failure.
|
Closing until we get another reproduction of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition on port availability by switching to port instead of log check.