chore: use testify instead of t.Error #2871

mmorel-35 · 2024-11-02T10:18:24Z

What does this PR do?

This uses github.com/stretchr/testify instead of t.Error calls

Why is it important?

This reduce the number of lines required to make an assertion.
It also make the assertion easier to understand.

Related issues

Relates [Enhancement]: use testify's require instead of assert. #2808

netlify · 2024-11-02T10:18:42Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`6b08eb8`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/67268759cc5b6a0008919f3a
😎 Deploy Preview	https://deploy-preview-2871--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh

Thanks for the PR, we're standardising on require instead of assert to so we get just a single error at a time, for the reasons described in one of the examples.

docker_client_test.go

docker_test.go

stevenh

As mentioned lets just standardise on require across the board to keep things simple.

docker_test.go

stevenh

Thanks for your continued work on these improvements, most appreciated.

In the interest of keeping things simple lets just keep everything using require so have commented on each use of assert.

generic_test.go

testcontainers_test.go

image_substitutors_test.go

Signed-off-by: Matthieu MOREL <[email protected]>

stevenh

Just one issue

provider_test.go

stevenh

LGTM, thanks for the quick revisions!

stevenh · 2024-11-03T10:14:13Z

Thanks again for all your efforts on this @mmorel-35 most appreciated!

* main: (34 commits) fix: only upload to sonar on ubuntu-latest (testcontainers#2891) fix: build artifact name properly (testcontainers#2890) fix: do not run sonar upload when ryuk is disabled (testcontainers#2889) fix: update GH actions for uploading/downloading artifacts (testcontainers#2888) feat(ci): Enable master moby with rootless (testcontainers#2880) fix(redpanda): temporary file use chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.8 (testcontainers#2676) chore(deps): bump actions/upload-artifact from 3.1.3 to 4.4.3 (testcontainers#2885) fix!: port forwarding clean up and make private (testcontainers#2881) chore: resolve AWS deprecations for localstack (testcontainers#2879) docs: fix new lifecycle hooks section (testcontainers#2875) fix: host access port instability (testcontainers#2867) feat: add build to life cycle hooks (testcontainers#2653) fix: typo in containerd integration (testcontainers#2873) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2806) chore: use testify instead of t.Error (testcontainers#2871) ci: enable perfsprint linter (testcontainers#2872) chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2807) chore: use testcontainers.RequireContainerExec (testcontainers#2870) chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (testcontainers#2868) ...

* main: (76 commits) fix(influxdb): Respect custom waitStrategy (testcontainers#2845) fix: only upload to sonar on ubuntu-latest (testcontainers#2891) fix: build artifact name properly (testcontainers#2890) fix: do not run sonar upload when ryuk is disabled (testcontainers#2889) fix: update GH actions for uploading/downloading artifacts (testcontainers#2888) feat(ci): Enable master moby with rootless (testcontainers#2880) fix(redpanda): temporary file use chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.8 (testcontainers#2676) chore(deps): bump actions/upload-artifact from 3.1.3 to 4.4.3 (testcontainers#2885) fix!: port forwarding clean up and make private (testcontainers#2881) chore: resolve AWS deprecations for localstack (testcontainers#2879) docs: fix new lifecycle hooks section (testcontainers#2875) fix: host access port instability (testcontainers#2867) feat: add build to life cycle hooks (testcontainers#2653) fix: typo in containerd integration (testcontainers#2873) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2806) chore: use testify instead of t.Error (testcontainers#2871) ci: enable perfsprint linter (testcontainers#2872) chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2807) chore: use testcontainers.RequireContainerExec (testcontainers#2870) ...

mmorel-35 requested a review from a team as a code owner November 2, 2024 10:18

mmorel-35 force-pushed the testifier/assert branch 2 times, most recently from d173e99 to 389504f Compare November 2, 2024 10:23