fix(redpanda): temporary file use #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
approved these changes
Nov 11, 2024
stevenh
changed the title
stevenh
force-pushed
the
remove-fs-writes
branch
from
6a75be2 to
63bbd4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Redpanda container does not write files to the local filesystem anymore. It uses
io.Readernow to copy files to the container.Why is it important?
On some environment it is not possible to write the startup files to the local filesystem and mount them into the container. For example in CI/CD environments where docker in docker is used. The files are written to the filesystem of container A. Then container A tries to start the redpanda container and passes the mount path to the newly created container. The redpanda container tries to mount the files from the host filesystem but cannot find them because they were written inside container A.
How to test this PR
Just run the container tests. Everything should be working like before.