Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wait): log sub match callback #2929

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat(wait): log sub match callback #2929

merged 2 commits into from
Dec 20, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Dec 20, 2024

Add support for a sub match callback to wait.LogStrategy which allows containers to process the matched pattern storing details or otherwise validating them.

The callback can return a PermanentError if no more retries should be attempted.

Add support for a sub match callback to wait.LogStrategy which allows containers
to process the matched pattern storing details or otherwise validating them.

The callback can return a PermanentError if no more retries should be attempted.
@github-actions github-actions bot added the feature New functionality or new behaviors on the existing one label Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 9ca35b0
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67657726c4ae31000839cfe7
😎 Deploy Preview https://deploy-preview-2929--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stevenh stevenh marked this pull request as ready for review December 20, 2024 13:54
@stevenh stevenh requested a review from a team as a code owner December 20, 2024 13:54
@mdelapenya mdelapenya self-assigned this Dec 20, 2024
@mdelapenya mdelapenya merged commit 63fad4d into main Dec 20, 2024
124 checks passed
@mdelapenya mdelapenya deleted the feat/wait-submatch branch December 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants